Compress notebook output streams before rendering #160667
Merged
+149
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
force-pushed
the
donjayamanne/moveTerminalStreamCompressionIntoCore
branch
from
2e48126 to
8b907e5
Compare
rebornix
reviewed
Sep 12, 2022
src/vs/workbench/contrib/notebook/browser/view/renderers/stdOutErrorPreProcessor.ts
Show resolved
Hide resolved
DonJayamanne
force-pushed
the
donjayamanne/moveTerminalStreamCompressionIntoCore
branch
from
c400e4a to
77a6d7a
Compare
rebornix
reviewed
Sep 12, 2022
|
|
||
| // Remove the previous line if required. | ||
| const command = stream.subarray(0, MOVE_CURSOR_1_LINE_COMMAND.length); | ||
| if (command[0] === MOVE_CURSOR_1_LINE_COMMAND_BYTES[0] && command[1] === MOVE_CURSOR_1_LINE_COMMAND_BYTES[0] && command[2] === MOVE_CURSOR_1_LINE_COMMAND_BYTES[0]) { |
rebornix
reviewed
Sep 12, 2022
rebornix
previously approved these changes
Sep 12, 2022
DonJayamanne
force-pushed
the
donjayamanne/moveTerminalStreamCompressionIntoCore
branch
from
e28d0f2 to
1fd5437
Compare
rebornix
reviewed
Sep 12, 2022
extensions/ipynb/src/serializers.ts
Outdated
| @@ -4,9 +4,11 @@ | |||
| *--------------------------------------------------------------------------------------------*/ | |||
|
|
|||
| import type * as nbformat from '@jupyterlab/nbformat'; | |||
| import { TextDecoder } from 'util'; | |||
There was a problem hiding this comment.
I think we don't need this import, not sure if having it explicit would break the browser build.
rebornix
approved these changes
Sep 12, 2022
DonJayamanne
deleted the
donjayamanne/moveTerminalStreamCompressionIntoCore
branch
DonJayamanne
added a commit
that referenced
this pull request
Sep 14, 2022
This reverts commit 4230c22.
DonJayamanne
added a commit
that referenced
this pull request
Sep 26, 2022
This reverts commit 4230c22.
DonJayamanne
added a commit
that referenced
this pull request
Sep 26, 2022
This reverts commit 4230c22.
DonJayamanne
added a commit
that referenced
this pull request
Oct 9, 2022
This reverts commit 4230c22.
DonJayamanne
added a commit
that referenced
this pull request
Oct 11, 2022
This reverts commit 4230c22.
DonJayamanne
added a commit
that referenced
this pull request
Oct 11, 2022
This reverts commit 4230c22.
DonJayamanne
added a commit
that referenced
this pull request
Oct 11, 2022
This reverts commit 4230c22.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode-jupyter#11031
Corresponding PR in Jupyter is here microsoft/vscode-jupyter#11350