Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debounce event handler on notebook editor open. #162975

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Debounce event handler on notebook editor open. #162975

merged 1 commit into from
Oct 7, 2022

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Oct 7, 2022

Handling these events on editor open will lead to DOM read/write in unwanted sequence and lead to more layout forced reflow.

@rebornix rebornix enabled auto-merge (squash) October 7, 2022 17:22
@rebornix rebornix self-assigned this Oct 7, 2022
@rebornix rebornix merged commit 30a8ab3 into main Oct 7, 2022
@rebornix rebornix deleted the rebornix/debounce-events-on-nb-open branch October 7, 2022 17:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amunger amunger amunger approved these changes

Assignees

@rebornix rebornix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebornix @amunger