Remove a few exports
#165158
Merged
Remove a few exports
#165158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Nov 1, 2022
| readonly onDidSendMessage: Event<DebugProtocol.Message>; | ||
| handleMessage(message: DebugProtocol.Message): void; | ||
| } | ||
|
|
||
| export interface IDebugAdapterImpl { | ||
| interface IDebugAdapterImpl { |
There was a problem hiding this comment.
Seems like this and IDebugAdapterInlineImpl should be exported since they are part of IAdapterDescriptor which is exported
There was a problem hiding this comment.
And IDebugAdapterExecutableOptions
There was a problem hiding this comment.
Indeed, the ts-unused-exports tool could be smarter and omit "indirect" exports...
There was a problem hiding this comment.
I've reverted the mentioned symbols.
weinand
force-pushed
the
aweinand/removeExports
branch
from
48adc2e to
137e79c
Compare
roblourens
approved these changes
Nov 1, 2022
weinand
added
the
debug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #164941