Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint: add a new rule to enforce declare _serviceBrand: undefined #165396

Merged
merged 1 commit into from
Nov 3, 2022
Merged

eslint: add a new rule to enforce declare _serviceBrand: undefined #165396

merged 1 commit into from
Nov 3, 2022

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Nov 3, 2022 •
edited
Loading

The _serviceBrand property is only needed for type checking, not at runtime. This rule enforces no value is set which in return means no output is generated. Saves a few bytes

@jrieken jrieken self-assigned this Nov 3, 2022
@jrieken jrieken enabled auto-merge (squash) November 3, 2022 17:01
@vscodenpa vscodenpa added this to the November 2022 milestone Nov 3, 2022
@jrieken jrieken mentioned this pull request Nov 3, 2022
Closed
@jrieken jrieken merged commit 98546b2 into main Nov 3, 2022
@jrieken jrieken deleted the joh/eslint-declare-service-brand branch November 3, 2022 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
November 2022
Development

Successfully merging this pull request may close these issues.
3 participants
@jrieken @rzhao271 @vscodenpa