Increase min-height to 100% #165566
Merged
Increase min-height to 100% #165566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
approved these changes
Nov 4, 2022
rzhao271
added a commit
that referenced
this pull request
Nov 7, 2022
rzhao271
added a commit
that referenced
this pull request
Nov 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165518
A min-height of 100% makes sense because the list of settings is often over 100% in height. In other words, one often has to scroll to see the entire list of settings.
I have confirmed neither the settings list nor the gear icon hover element overlap with the taskbar.