Put marker hovers on top #166560
Put marker hovers on top #166560
Conversation
|
@microsoft-github-policy-service agree |
|
@rebornix could this have a look? |
|
some more examples of errors on top: Millet
rust-analyzer
|
|
Hi @rzhao271 and @daviddossett, if you have a minute could you take a look at this PR? Based on the corresponding issue (#73120), this would fix a UX issue that many people have been struggling with for a while (opened 2019, >110 reactions, no negative comments). It also looks like the actual code changes are minimal, so this is primarily a design decision. Thank you both for your time! |
There was a problem hiding this comment.
After this change is merged, for short hovers, if the hover is going downwards, then the error appears closer to the error squiggle, and if the hover is going upwards, then the error appears farther from the error squiggle.
For long hovers in either direction, because the user currently needs to scroll to the bottom of the hover just to see the error, the error appearing at the top instead, which would be provided by merging this PR, is good, because users wouldn't have to scroll anymore just to see the error message.
LGTM
I'll wait for @alexdima to provide a second approval, though.
|
Any progress on this? |
|
@alexdima are you able to approve this? |
Description
This puts marker hovers on top of all other hover kinds, and shifts down all hover kinds that used to be ahead of marker hovers by 1.
An effect of this is that diagnostic messages are now on top when hovering.
Before
After
Closes
Close #73120
Tests
👀