-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support to open both integrated terminal and external terminal with … #168879
Conversation
@Tyriar If we want to two different command,We may need two items?and if we need to hide dynamically when changing configurations, that might also need to save the reference for the call to dispose. I don't know if my thinking is right, the code is a bit ugly, if the idea is indeed like this, I will improve it, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, this is a good start 👍
src/vs/workbench/contrib/externalTerminal/browser/externalTerminal.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/externalTerminal/browser/externalTerminal.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/externalTerminal/browser/externalTerminal.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/externalTerminal/browser/externalTerminal.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/externalTerminal/browser/externalTerminal.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/externalTerminal/browser/externalTerminal.contribution.ts
Outdated
Show resolved
Hide resolved
@Tyriar Because something delayed for a while, current logic is that there are only two commands, but I'm not sure how to run the remote test, need your help |
@weartist to get a remote window you run the new testresolver window via the command palette, that creates a fake remote window that connects to the local machine. |
@Tyriar |
@Tyriar not sure if this modification is appropriate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay, works great 👍
@Tyriar seems that someone else needs to approve |
Asked someone on team to review |
resolved #167688