Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix terminal locale handling #169072

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Fix terminal locale handling #169072

merged 1 commit into from
Dec 14, 2022

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Dec 14, 2022 •
edited
Loading

Fixes #166936

Candidate PR version of #169068

This PR breaks language pack recommendation in order to get the terminal working again on macOS with non-ASCII characters.

@rzhao271 rzhao271 self-assigned this Dec 14, 2022
@rzhao271 rzhao271 added this to the November 2022 Recovery 1 milestone Dec 14, 2022
@rzhao271 rzhao271 force-pushed the rzhao271/terminal-cand branch from f160518 to bf38e3a Compare December 14, 2022 09:18
@deepak1556
Copy link
Collaborator

Can this just be disabled for macOS to keep the candidate change minimal ?

deepak1556
deepak1556 previously approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need a follow-up debt issue to remove this workaround and make the api available on macOS :)

@deepak1556 deepak1556 added the candidate Issue identified as probable candidate for fixing in the next release label Dec 14, 2022
@rzhao271 rzhao271 force-pushed the rzhao271/terminal-cand branch from 132c904 to bf38e3a Compare December 14, 2022 09:51
@rzhao271 rzhao271 mentioned this pull request Dec 14, 2022
Merged
@aeschli aeschli enabled auto-merge (squash) December 14, 2022 09:56
@aeschli aeschli merged commit 1ad8d51 into release/1.74 Dec 14, 2022
@aeschli aeschli deleted the rzhao271/terminal-cand branch December 14, 2022 10:05
@TylerLeonhardt TylerLeonhardt mentioned this pull request Dec 15, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@aeschli aeschli aeschli approved these changes

Assignees

@rzhao271 rzhao271

Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
November 2022 Recovery 1
Development

Successfully merging this pull request may close these issues.
3 participants
@rzhao271 @deepak1556 @aeschli