-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update node-pty@0.11.0-beta27 #171583
Conversation
@deepak1556 can you run a product build as well? I've been wanting to update this for like a year but never got it passing a build due to unknown failures. |
Oh yeah, then there's distro complications you need to fix and it ends up failing: #170123 |
FYI it was this PR that broke us updating: microsoft/node-pty#487 |
Thanks for the context, I will investigate the failures today. |
Turned out to be a packaging issue which is why the issue was isolated to product builds, the new helper executable was ignored because of missing file extension. |
7060d5c
to
d528a63
Compare
I reverted the distro change to make it easier for merge, will perform the changes in |
Thanks @deepak1556! |
Breaking out the relevant change from #166430