Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node-pty@0.11.0-beta27 #171583

Merged
merged 4 commits into from
Jan 19, 2023
Merged

chore: update node-pty@0.11.0-beta27 #171583

merged 4 commits into from
Jan 19, 2023

Conversation

deepak1556
Copy link
Collaborator

Breaking out the relevant change from #166430

@deepak1556 deepak1556 added this to the January 2023 milestone Jan 18, 2023
@deepak1556 deepak1556 self-assigned this Jan 18, 2023
@deepak1556 deepak1556 marked this pull request as ready for review January 18, 2023 07:30
@deepak1556 deepak1556 enabled auto-merge (squash) January 18, 2023 07:30
@Tyriar
Copy link
Member

Tyriar commented Jan 18, 2023

@deepak1556 can you run a product build as well? I've been wanting to update this for like a year but never got it passing a build due to unknown failures.

@deepak1556
Copy link
Collaborator Author

@Tyriar
Copy link
Member

Tyriar commented Jan 18, 2023

Oh yeah, then there's distro complications you need to fix and it ends up failing: #170123

@Tyriar
Copy link
Member

Tyriar commented Jan 18, 2023

FYI it was this PR that broke us updating: microsoft/node-pty#487

@deepak1556
Copy link
Collaborator Author

Thanks for the context, I will investigate the failures today.

@deepak1556
Copy link
Collaborator Author

Turned out to be a packaging issue which is why the issue was isolated to product builds, the new helper executable was ignored because of missing file extension.

@deepak1556
Copy link
Collaborator Author

@deepak1556
Copy link
Collaborator Author

I reverted the distro change to make it easier for merge, will perform the changes in vscode-distro branch post merge.

@deepak1556 deepak1556 merged commit fdb2bef into main Jan 19, 2023
@deepak1556 deepak1556 deleted the robo/update_node_pty branch January 19, 2023 10:12
@Tyriar
Copy link
Member

Tyriar commented Jan 19, 2023

Thanks @deepak1556!

@Tyriar Tyriar mentioned this pull request Jan 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants