-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an AppData XML data file to Linux builds #17369
Conversation
Hi @aperezdc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
<component type="desktop"> | ||
<id>@@NAME@@.desktop</id> | ||
<metadata_license>CC-BY-SA-3.0</metadata_license> | ||
<project_license>MIT</project_license> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be sourced from product.licenseName
now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I'll rebase the branch and do precisely that.
<?xml version="1.0" encoding="UTF-8"?> | ||
<component type="desktop"> | ||
<id>@@NAME@@.desktop</id> | ||
<metadata_license>CC-BY-SA-3.0</metadata_license> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave this as MIT for now as I don't think we use a special license for metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this value come from product.licenseName
as well, then.
The AppData files provide descriptive data about an application, and is typically used in application managers to display additional information to the user. Having an AppData file is especially important for some graphical application installers: without one, an application manager may not event show an entry for the application. This happens for example in GNOME Software. For the sake of completeness, this commit not only adds the AppData file to the Flatpak build, but also to the Linux .deb and .rpm packages.
Updated! |
Thanks for the quick turn around @aperezdc, this is great 😄 |
@Tyriar: You're welcome! Also, it is being nice contributing to VS Code — kudos for caring about keeping the community healthy 😄 |
The AppData files provide descriptive data about an application, and is typically used in application managers to display additional information to the user. Having an AppData file is especially important for some graphical application installers: without one, an application manager may not event show an entry for the application. This happens for example in GNOME Software.
For the sake of completeness, this commit not only adds the AppData file to the Flatpak build, but also to the Linux .deb and .rpm packages.
This is follow-up to PR #16169 and a complement to issue #7112.