Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an AppData XML data file to Linux builds #17369

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Add an AppData XML data file to Linux builds #17369

merged 1 commit into from
Dec 19, 2016

Conversation

aperezdc
Copy link
Contributor

The AppData files provide descriptive data about an application, and is typically used in application managers to display additional information to the user. Having an AppData file is especially important for some graphical application installers: without one, an application manager may not event show an entry for the application. This happens for example in GNOME Software.

For the sake of completeness, this commit not only adds the AppData file to the Flatpak build, but also to the Linux .deb and .rpm packages.


This is follow-up to PR #16169 and a complement to issue #7112.

@msftclas
Copy link

Hi @aperezdc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

<component type="desktop">
<id>@@NAME@@.desktop</id>
<metadata_license>CC-BY-SA-3.0</metadata_license>
<project_license>MIT</project_license>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be sourced from product.licenseName now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I'll rebase the branch and do precisely that.

<?xml version="1.0" encoding="UTF-8"?>
<component type="desktop">
<id>@@NAME@@.desktop</id>
<metadata_license>CC-BY-SA-3.0</metadata_license>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave this as MIT for now as I don't think we use a special license for metadata.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this value come from product.licenseName as well, then.

@Tyriar Tyriar added this to the January 2017 milestone Dec 16, 2016
The AppData files provide descriptive data about an application, and is
typically used in application managers to display additional information to
the user. Having an AppData file is especially important for some graphical
application installers: without one, an application manager may not event
show an entry for the application. This happens for example in GNOME Software.

For the sake of completeness, this commit not only adds the AppData file to
the Flatpak build, but also to the Linux .deb and .rpm packages.
@aperezdc
Copy link
Contributor Author

Updated!

@Tyriar
Copy link
Member

Tyriar commented Dec 19, 2016

Thanks for the quick turn around @aperezdc, this is great 😄

@Tyriar Tyriar merged commit 9769cd9 into microsoft:master Dec 19, 2016
@aperezdc
Copy link
Contributor Author

@Tyriar: You're welcome! Also, it is being nice contributing to VS Code — kudos for caring about keeping the community healthy 😄

@aperezdc aperezdc deleted the linux-appstream-xml branch December 19, 2016 13:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants