Enable a tooltip in quick pick #174417
Enable a tooltip in quick pick #174417
Conversation
| if (!element.element || !element.saneTooltip) { | ||
| return; | ||
| } | ||
| this._lastHover = this.options.hoverDelegate.showHover({ |
There was a problem hiding this comment.
IHoverOptions.id is available now on main
| return this.hoverService.showHover({ | ||
| ...options, | ||
| hideOnHover: false, | ||
| hideOnKeyDown: false, | ||
| skipFadeInAnimation: true, | ||
| }, focus); |
There was a problem hiding this comment.
This also breaks the equality check, but id would fix it
* hover in quickpick * refactoring * fix tests * remove HTMLElement from API for now * API proposal
| case KeyCode.Space: | ||
| if (event.ctrlKey) { |
There was a problem hiding this comment.
@TylerLeonhardt there's a couple of potential issues with this solution regarding keyboard accessibility.
In order to be discoverable, this should either be conveyed to the user through markup (as in, "has tooltip, press [ .. ] to activate". or at least be a well-known key combination across users (such as Shift+F1).
Additionally note that Ctrl is actually the key that's commonly used to dismiss tooltips rather than summon them in many Windows applications and is preferred by many keyboard users due to that.
There was a problem hiding this comment.
probably should be resolved somehow in #175662
This PR introduces an ability for a Core feature to provide a tooltip for a QuickPickItem.
ctrl+spaceto toggle the tooltip or hover over an item with your mouse to show the hoverFixes #174473