provide screen reader with inline suggestions

[meganrogge]

cc @isidorn

[jooyoungseo]

@meganrogge -- The best way for me to test this feature would be after it is released to insider because I don't know how to trigger inline suggestions like copilot in dev version. I usually test the inline suggestion with copilot extension, but as you know, I cannot use any extensions in dev version.

[meganrogge]

You can load the extension by downloading and loading the .vsix file, but I am able to test this so can proceed based on that

[Tyriar]

You're probably best off getting a review from someone familiar with monaco for this one

[blaise80]

Pa fout janm voye message sou email ça anko ok Le lun. 6 mars 2023 15:43, Megan Rogge ***@***.***> a écrit :

…

***@***.**** commented on this pull request. ------------------------------ In src/vs/editor/common/standalone/standaloneEnums.ts <#175823 (comment)>: > - wordWrap = 125, - wordWrapBreakAfterCharacters = 126, - wordWrapBreakBeforeCharacters = 127, - wordWrapColumn = 128, - wordWrapOverride1 = 129, - wordWrapOverride2 = 130, - wrappingIndent = 131, - wrappingStrategy = 132, - showDeprecated = 133, - inlayHints = 134, - editorClassName = 135, - pixelRatio = 136, - tabFocusMode = 137, - layoutInfo = 138, - wrappingInfo = 139 + screenReaderAnnounceInlineSuggestion = 6, Henning had reviewed and approved these changes before, but will do for safety — Reply to this email directly, view it on GitHub <#175823 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APGKWH4X5YMCJ24WPFRLK4TW2ZD5PANCNFSM6AAAAAAVMXNOFA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[meganrogge]

@hediet when I tried this, I didn't see an issue with audio cues/ debouncing. Could you pls suggest the repro steps for the issue you mentioned in the other PR and/or what you'd suggest?

discussed with Henning and JooYoung the points of concern

[meganrogge]

@jooyoungseo this is available for testing in insider's with editor.screenReaderAnnounceInlineSuggestion: true - be aware if you update at the moment though, there are some issues with the terminal accessible buffer

#176219
#176197

[jooyoungseo]

@meganrogge -- Thanks! I have tested this morning and have found some issues, but hard to explain. I will take some time next week to file an issue. To cut To the chase, the suggestion live event is read aloud twice (tested with NVDA).