Welcome Dialog Service

[bhavyaus]

Related: #166895
The welcomeDialogService uses the existing

vscode/src/vs/base/browser/ui/dialog/dialog.ts

Line 69 in 040a680

export class Dialog extends Disposable {

to create a welcome modal dialog.

[bpasero]

I am a little bit confused why we now have a modalDialogService. To clarify, we already have IDialogService and it opens modal dialogs (either native or custom). Why do we need a second service?

If we can move the functionality into the IDialogService that would be better, otherwise for a developer it will be hard to tell apart dialog service from modal dialog service.

[bhavyaus]

I am a little bit confused why we now have a modalDialogService. To clarify, we already have IDialogService and it opens modal dialogs (either native or custom). Why do we need a second service?

If we can move the functionality into the IDialogService that would be better, otherwise for a developer it will be hard to tell apart dialog service from modal dialog service.

Fixed.
This dialog is specific to the welcome view (see related: #166895) .
Moved and renamed service to include the welcome prefix.

[bpasero]

Why not just welcomeDialog? To me, every dialog is modal by definition.

Thanks Ben. Since there are no other architecture changes, ill remove you from this PR. I did update the comment as you requested.