Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when a screen reader is detected, do not apply notebook cell navigation keybindings #179191

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

meganrogge
Copy link
Contributor

fix #176286

@meganrogge meganrogge requested a review from rebornix April 4, 2023 19:30
@meganrogge meganrogge self-assigned this Apr 4, 2023
@meganrogge meganrogge added this to the April 2023 milestone Apr 4, 2023
@meganrogge meganrogge changed the title don't show cell navigation commands when a screen reader is detected when a screen reader is detected, do not apply notebook cell navigation keybindings Apr 4, 2023
@meganrogge meganrogge requested a review from rebornix April 4, 2023 22:07
@meganrogge meganrogge merged commit 000b988 into main Apr 5, 2023
@meganrogge meganrogge deleted the merogge/notebook branch April 5, 2023 02:43
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allowNavigateToSurroundingCells should be false when screen reader is detected
2 participants