Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show hover message for diff revert arrow #180378

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Conversation

joyceerhl
Copy link
Contributor

@joyceerhl joyceerhl commented Apr 20, 2023

Re: #179725

We now potentially show both breakpoints and diff editor revert icons in the diff editor. It's ambiguous what happens when the user clicks on the revert icon. This PR adds a hover message so it's clear that clicking will revert the change. (Note, we will eventually implement support for glyph widgets, but this avoids ambiguity till then.)

image

@joyceerhl joyceerhl enabled auto-merge (squash) April 20, 2023 04:16
@joyceerhl joyceerhl self-assigned this Apr 20, 2023
@joyceerhl joyceerhl requested a review from hediet April 20, 2023 04:16
@vscodenpa vscodenpa added this to the April 2023 milestone Apr 20, 2023
@joyceerhl joyceerhl force-pushed the dev/joyceerhl/provincial-cheetah branch from 356eb34 to a7b641e Compare April 20, 2023 04:21
@hediet
Copy link
Member

hediet commented Apr 24, 2023

I think this fixes some open issue. Thanks for the fix!

hediet
hediet previously approved these changes Apr 24, 2023
@joyceerhl joyceerhl merged commit 8df6888 into main Apr 24, 2023
@joyceerhl joyceerhl deleted the dev/joyceerhl/provincial-cheetah branch April 24, 2023 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants