testing: tie test output correctly to runs, rework ui accordingly #180746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an old artifact that caused problems in the issue this fixes #180041 When we get a new 'task' from a test run request, we automatically marked all tests as being enqueued with it. However, tests are now lazily added to the test run states, so this would only affect tests that _already_ had their state set to something (e.g. in another task). And therefore it was also ineffective for its original purpose of marking all included tests as being Queued, since extensions have had to do that themselves anyway. So just remove this code! Also, adjust priorities such that "skipped" priorities are shown above unset ones.
Previously, test output was handled for an entire TestRunRequest into a single stream. This didn't match what the public API implied, nor what the real intentions were. This makes output be stored correctly on a per-test run (called "tasks" internally). It changes the order of the Test Results view so that tests nested under their task, and also improves some of the tree handling there to update nodes more specifically. Clicking on the "terminal" button in the test view continues to show output from the last test run request, but if there were multiple tasks, the user is asked to choose which they want to view output for. Finally I removed some old unused code that dealt with storing test results on disk, which we no longer do, and moved to a simpler interface instead. Fixes #180041
roblourens
approved these changes
Apr 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, test output was handled for an entire TestRunRequest into
a single stream. This didn't match what the public API implied, nor what
the real intentions were.
This makes output be stored correctly on a per-test run (called "tasks"
internally). It changes the order of the Test Results view so that tests
nested under their task, and also improves some of the tree handling
there to update nodes more specifically.
Clicking on the "terminal" button in the test view continues to show
output from the last test run request, but if there were multiple tasks,
the user is asked to choose which they want to view output for.
Finally I removed some old unused code that dealt with storing test
results on disk, which we no longer do, and moved to a simpler interface
instead.
Fixes #180041