Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clicking to remove breakpoint even alongside non debug decorations #180986

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

joyceerhl
Copy link
Contributor

No description provided.

@joyceerhl joyceerhl enabled auto-merge (squash) April 26, 2023 22:26
@joyceerhl joyceerhl self-assigned this Apr 26, 2023
@vscodenpa vscodenpa added this to the April 2023 milestone Apr 26, 2023
@joyceerhl joyceerhl merged commit 0a778a5 into main Apr 26, 2023
@joyceerhl joyceerhl deleted the dev/joyceerhl/semantic-marmot branch April 26, 2023 22:41
@gjsjohnmurray
Copy link
Contributor

Does this resolve #180789? It was too late for the Insiders I've got today (326dc5a), and seeing that the endgame issue shows Insiders builds have been paused I wonder if this PR needs to be tagged as a candidate.

@gjsjohnmurray
Copy link
Contributor

I tested this in today's Insiders with my testprovider extension. Recording below shows that the click on the breakpoint correctly toggles it off but incorrectly runs the test.

junk

Version: 1.78.0-insider
Commit: d6290ef
Date: 2023-04-27T05:20:48.295Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.78.0-insider Chrome/108.0.5359.215 Electron/22.4.8 Safari/537.36

@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants