-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added use snippet body as a description when none is provided #181115 #181381
Added use snippet body as a description when none is provided #181115 #181381
Conversation
- use snippet body as a description when none is provided #181115 - editor.snippets.fillDescriptions.enabled toggle in settings
@microsoft-github-policy-service agree |
@TheSylvester Thanks. This is already looking pretty good.
I would like to disagree with that and implement this w/o setting. |
I should clarify that I implemented a setting to toggle this to be enabled. By default I've set this to be false to be optionally enabled, unless you see something different? |
That's what I see but I am saying that a setting isn't needed. This is an improvement and shouldn't be behind a setting but just happen |
I see! I was just following the ethos of making as few changes as possible, especially to default behaviour. Just accounting for folks who would appreciate being able to see their snippet without the description (maybe that's why they didn't put one in). There's definitely a case for making this default true but I leave that up to the maintainers. |
We take improvement without setting, so please remove that part in the PR |
Thank you for confirming. I've made the required changes. Kindly let me know if there's anything else required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
edit: added word "implemented"