Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary nodeJS walkthrough #181442

Merged
merged 1 commit into from
May 3, 2023

Conversation

bhavyaus
Copy link
Collaborator

@bhavyaus bhavyaus commented May 3, 2023

Fixes: #181400
This is a temp fix.

Commit 9302611 removes a walkthrough from a builtin extension.
The place where we are stuck

await this.gettingStartedService.installedExtensionsRegistered;
is waiting on a promise that only resolves when an extension’s contributed walkthroughs are processed, and with that commit, we no longer have any builtin extensions contributing a walkthrough.

Temporary fix is to add in a placeholder walkthrough that is disabled with a when clause and that gets everything working the way it did before.

PR in main: #181441

@bhavyaus bhavyaus requested a review from roblourens May 3, 2023 19:22
@roblourens roblourens enabled auto-merge (squash) May 3, 2023 19:24
@roblourens roblourens merged commit 252e546 into release/1.78 May 3, 2023
@roblourens roblourens deleted the dev/bhavyau/ext-walkthrough-release branch May 3, 2023 19:37
Copy link

@Salome085 Salome085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants