Adding the resizable content hover code without the persistance mechanism #185540

aiday-mar · 2023-06-19T07:50:41Z

This PR builds atop the initial PR on making content hovers resizable. The aim of this PR is to separate the code which does the persistance from the code which does the resizing. The persistance mechanism can be added later.

… implement the resizable hover and the resizable suggest widget

…t why

…nt widget appear, now need to resize is correctly

…ction

…ther the code

…factors into an inteface

… content widget of the resizable hover widget

…tentChanged function

…th hovers with no initial horizontal scrollbar

src/vs/base/browser/ui/hover/hover.css

src/vs/editor/contrib/hover/browser/hover.ts

src/vs/editor/contrib/hover/browser/contentHover.ts

src/vs/editor/contrib/hover/browser/resizableContentWidget.ts

src/vs/editor/contrib/hover/browser/contentHover.ts

… into the content hover

…he z-index to 50 on the hover widget

…e store

…sistance

aiday-mar added 30 commits March 31, 2023 15:57

creating a generic resizable content widget type which can be used to…

f6fc074

… implement the resizable hover and the resizable suggest widget

adding code for the hover specific widgets and content widgets

ea010f6

Adding some code

f5c37fb

commenting some method

642b208

removed some of the errors appearing, verify it all works later

17ca49d

resolving the cyclic dependency, the hover no longer appears, find ou…

3687cff

…t why

cleaning the code

4d13019

made sashes red in order to be able to debug

27c777e

adding the content widget inside of showAt in order to have the conte…

b7c313b

…nt widget appear, now need to resize is correctly

now we see the red sash after changing the layout

3ed8eae

also adding the layxout of the element into the onContentsChanges fun…

7d65d19

…ction

find out why the widget disappears when you hover on it, simplify fur…

a5e5f8d

…ther the code

first simplify maximally and clean the code, then extract the common …

9dc9fe7

…factors into an inteface

changing the code so that hover does not disappear on hovering on the…

41d4ad3

… content widget of the resizable hover widget

saving the changes

8f94dec

does no longer automatically disappear on sash click

4b5622e

changing the id to the correct id of the resizable hover widget

c81cd86

changing the pixel positions for better rendering

3387388

using the check on the horizontal scrollbar of height 10 in the onCon…

6365481

…tentChanged function

removing 7 in the resize function

add96e1

changing the pixel values

aadd76e

removing some redundant code

1b7f36c

updating where the rendering is directly in the content widget

f1a1c6d

adding code for enabling the correct sashes

cb0687b

cleaning the code

72a9e3b

changing the pixel change

5b5bd72

cleaning the code

8a07e1d

changing pixel sizes, need to further improve pixel sizes

e7b4497

Adding a command in order to be able to clear the persisted hover sizes

94ae3ac

works on hovers with horizontal scroll-bar, find why does not work wi…

73737cd

…th hovers with no initial horizontal scrollbar

adding the initial code for just the resizing without the persisting

a28db3e

jrieken reviewed Jun 19, 2023

View reviewed changes

aiday-mar added 18 commits June 19, 2023 13:23

calling instead hide widgets when we know we are not resizing

ab90467

adding .monaco-hover inside of the CSS

2b65bd2

adding review chanegs

5a927a7

Don't remove code for isHoverSticky

6d67967

removing beforeOnDidWillResize and afterOnDidWillResize

36fd1e0

removing the position from the resizable content widget and adding it…

0bdacdb

… into the content hover

removing the css changes that have been previously done and setting t…

8755ad6

…he z-index to 50 on the hover widget

using the register function instead of using the additional disposabl…

2e83346

…e store

changes from review from yesterday

2483e08

not using the sash width in the calculation of the height

3bbd621

keeping the size the same for the hover widget

6e34da5

changing the code order

52a78d8

adding explaining comment

c35e990

Merge branch 'main' into aiday/addingResizableContentWidgetWithoutPer…

8b81627

…sistance

removing the additional semi-colon

977962b

remove the extra

2c43a89

cleaning the code

7b79a27

layout of color picker on resize

153ea1f

jrieken previously approved these changes Jun 21, 2023

View reviewed changes

setting both to protected

6f00b57

aiday-mar dismissed jrieken’s stale review via 6f00b57 June 21, 2023 10:09

aiday-mar marked this pull request as ready for review June 21, 2023 10:09

jrieken approved these changes Jun 21, 2023

View reviewed changes

aiday-mar enabled auto-merge June 21, 2023 10:09

vscodenpa added this to the June 2023 milestone Jun 21, 2023

aiday-mar merged commit cf23221 into main Jun 21, 2023

aiday-mar deleted the aiday/addingResizableContentWidgetWithoutPersistance branch June 21, 2023 10:23

github-actions bot locked and limited conversation to collaborators Aug 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding the resizable content hover code without the persistance mechanism #185540

Adding the resizable content hover code without the persistance mechanism #185540

aiday-mar commented Jun 19, 2023 •

edited

Loading

Adding the resizable content hover code without the persistance mechanism #185540

Adding the resizable content hover code without the persistance mechanism #185540

Conversation

aiday-mar commented Jun 19, 2023 • edited Loading

aiday-mar commented Jun 19, 2023 •

edited

Loading