cli: stop tunnel processes during update #187738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceerhl
reviewed
Jul 12, 2023
| if IsNotBackgroundUpdate() and not StopTunnelOtherProcesses() then | ||
| Result := '{#NameShort} is still running a tunnel process. Please stop the tunnel before installing.' | ||
| else | ||
| Result := ''; |
There was a problem hiding this comment.
I don't have a ton of context on this code, but do we have the ability to restart the stopped tunnel processes after the update is done?
There was a problem hiding this comment.
We do, and do so automatically, if they're running code tunnel. But there are some other commands like code tunnel service log that we prefer to kill and don't have a way of restoring, which is what the original issue was about. This catches these.
joyceerhl
approved these changes
Jul 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183715