Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix can't use cmd+up/down in terminal after closing find widget #187781

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix can't use cmd+up/down in terminal after closing find widget #187781

merged 1 commit into from
Jul 13, 2023

Conversation

jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Jul 13, 2023 •
edited
Loading

Fix #186781

Force focus when hiding find widget as terminalInstance.focus checks window.getSelection

@jeanp413 jeanp413 mentioned this pull request Jul 13, 2023
Closed
Tyriar
Tyriar approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down

@Tyriar Tyriar added this to the July 2023 milestone Jul 13, 2023
@Tyriar Tyriar enabled auto-merge July 13, 2023 15:05
@Tyriar Tyriar merged commit f102dfa into microsoft:main Jul 13, 2023
@jeanp413 jeanp413 deleted the fix-186781 branch July 13, 2023 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
July 2023
Development

Successfully merging this pull request may close these issues.

Can't use cmd+up/down in terminal after closing find widget
3 participants
@jeanp413 @Tyriar @meganrogge