fix: Close #187795, Language pack files for some extensions not found #187796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @TylerLeonhardt @bpasero Do you take up a little time to review the code for me? |
|
I would like to understand where the upper case CN is coming from... is that the browser? Does |
Yes. console of chrome safari and firefox respectively
|
|
It looks like there are only a few examples on MDN, not a complete list of languages. However, there are relevant language codes in the chromium source code which may be used as a reference. |
|
Closing this as this should be fixed now. See: #187795 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve an issue where some extended language packs fail to load
