Support Local File Links from the Markdown Preview #18824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#989 **Bug** * `file://` links do not work in the markdown preview. * `./file` and `/file` and `file` links do not work in the markdown preview. **Fix** For the first issue, allow `file://` links explicitly. Add a custom link validator. If the incoming link has no scheme, try to resolve it relative to the current file or workspace. Likes like `/file` are relative to the workspace, while links like `file` or `./file` are relative to the current file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #989
Bug
file://links do not work in the markdown preview../file.extand/file.extandfile.extlinks do not work in the markdown preview.Fix
For the first issue, allow
file://links explicitly.For the second, add a custom link normalizer. If the incoming link has no scheme, try to resolve it relative to the current file or workspace. Links like
/file.extare relative to the workspace, while links likefile.extor./file.extare relative to the current file.Also did some refactoring to extract renderer to own file