Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: plural naming #188887

Closed
wants to merge 5 commits into from
Closed

chore: plural naming #188887

wants to merge 5 commits into from

Conversation

yiliang114
Copy link
Contributor

provider -> providers

@bhavyaus bhavyaus assigned jrieken and unassigned bhavyaus Jul 26, 2023
@yiliang114
Copy link
Contributor Author

@jrieken Can you give me a look

@jrieken jrieken added this to the August 2023 milestone Aug 8, 2023
@jrieken
Copy link
Member

jrieken commented Aug 8, 2023

Thanks for you PR but we aren't taking purely cosmetic changes

@jrieken jrieken closed this Aug 8, 2023
@yiliang114
Copy link
Contributor Author

Thanks for you PR but we aren't taking purely cosmetic changes

But it is semantically wrong, shouldn't it be plural here?

@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@victor-hugo-ig victor-hugo-ig victor-hugo-ig approved these changes

Assignees

@jrieken jrieken

Labels
triage-needed
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.
5 participants
@yiliang114 @jrieken @victor-hugo-ig @bhavyaus @vscodenpa