Links are not automatically pasted as Markdown link if nothing is selected #189338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
reviewed
Jul 31, 2023
| }); | ||
|
|
||
| test('Should evaluate pasteAsMarkdownLink as false for selected whitespace and new lines', () => { | ||
| skinnyDocument.getText = function () { return ' \r\n\r\n'; }; |
There was a problem hiding this comment.
In a future pr, try to move off of setting methods like this. Instead create a new instance of a document for each tests case
mjbvz
approved these changes
Jul 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If nothing (or whitespace or new lines) is selected, the link will paste as plain text: #188871
However, if a markdown link is selected, the link will be pasted as a markdown link with a default 'Title.' I will change this so that plain text is pasted.