Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reindent all lines #18958

Merged
merged 3 commits into from
Jan 23, 2017
Merged

Reindent all lines #18958

merged 3 commits into from
Jan 23, 2017

Conversation

rebornix
Copy link
Member

Reindent all lines based on the language specific indentation rules.

@egamma egamma mentioned this pull request Jan 23, 2017
56 tasks
@alexdima alexdima merged commit 61ea4c2 into microsoft:master Jan 23, 2017
@alexdima
Copy link
Member

LGTM

@alexdima alexdima added this to the January 2017 milestone Jan 23, 2017
@alexdima
Copy link
Member

@rebornix Remember to create a test plan item for this.

@DonJayamanne
Copy link
Contributor

@rebornix @alexandrudima
Is there anything that I need to do to get this command to do something for Python files?
Currently nothing happens when executing this command for python files.

@rebornix
Copy link
Member Author

rebornix commented Feb 1, 2017

@DonJayamanne A proper Indentation Rules will do and this is how TypeScript does it https://github.com/Microsoft/vscode/blob/master/extensions/typescript/src/typescriptMain.ts#L195
For your information, Atom has builtin support for Python Indentation https://github.com/atom/language-python/blob/719e4404d2cd25a888a8111c62abd31a22a15ef3/settings/language-python.cson#L7 and you can get an idea from that. But since Python takes tab/spaces seriously, I'll suggest to give it a thorough test.

@DonJayamanne
Copy link
Contributor

@rebornix Thanks for the pointers. I already have the onEnter rules, I will just need to re-use them for the indentationRules, along with the decreaseIndent pattern from Atom.
Thanks

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants