Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for context view to hide so screen reader detects focus change, add toolbar #189950

Merged
merged 7 commits into from
Aug 8, 2023

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Aug 8, 2023

cc @rperez030 this now works and feels nice

still some context key issues to fix which cause the actions to become disabled. that can happen in a separate PR and I have deferred #189981 as it's not that important IMO.

part of #189675 and #189486

@meganrogge meganrogge self-assigned this Aug 8, 2023
@meganrogge meganrogge added this to the August 2023 milestone Aug 8, 2023
@meganrogge meganrogge enabled auto-merge August 8, 2023 16:44
@meganrogge meganrogge requested a review from Tyriar August 8, 2023 17:57
@meganrogge meganrogge changed the title wait for context view to hide so screen reader detects focus change wait for context view to hide so screen reader detects focus change, add toolbar Aug 8, 2023
@meganrogge meganrogge merged commit e6fcbab into main Aug 8, 2023
@meganrogge meganrogge deleted the merogge/help-dialog-screen-reader branch August 8, 2023 22:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants