Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow hover actions to show up in accessible view #190196

Closed
wants to merge 1 commit into from

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Aug 10, 2023

part of #189486

I'm starting to wonder if this is the right approach for hovers that contribute links. It makes sense for hovers without them and for hovers with only actions, like the terminal one.

Screenshot 2023-08-10 at 10 57 17 AM

How do we represent links within the accessible view? Do we make them into actions? Is that just complicating things?

Screenshot 2023-08-10 at 11 10 02 AM

Screenshot 2023-08-10 at 10 56 02 AM

Should we only suggest opening the accessible view for hovers which don't have URIs like the terminal one? Is there a way to detect this?

Should we even use the accessible view here or instead when alt+f2 is used, toggle between a readonly and editable monaco editor?

@meganrogge meganrogge requested a review from Tyriar August 10, 2023 18:28
@meganrogge meganrogge marked this pull request as draft August 10, 2023 18:28
@meganrogge
Copy link
Contributor Author

maybe we should get feedback on if users really benefit from the notification accessible view with integrated actions before proceeding here?

I think getting the link info is not going to be easy

@meganrogge
Copy link
Contributor Author

We are going to go with the simpler approach here - when a user wants to inspect the text, they can open the accessible view. To action the hover or go to a link, they can use the very accessible and tabbable existing hover.

@meganrogge meganrogge closed this Aug 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
@meganrogge meganrogge deleted the merogge/hover-actions-view branch October 26, 2023 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant