allow hover actions to show up in accessible view #190196
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #189486
I'm starting to wonder if this is the right approach for hovers that contribute links. It makes sense for hovers without them and for hovers with only actions, like the terminal one.
How do we represent links within the accessible view? Do we make them into actions? Is that just complicating things?
Should we only suggest opening the accessible view for hovers which don't have URIs like the terminal one? Is there a way to detect this?
Should we even use the accessible view here or instead when
alt+f2
is used, toggle between a readonly and editable monaco editor?