Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve accessibility of inline completions #190531

Merged
merged 12 commits into from
Aug 16, 2023

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Aug 15, 2023

This:

  • Adds an inline completion accessible view
  • Adds a hint to open that (EditorOption / verbosity setting controlled)
  • Changes the accessible view's aria label from a hint to open the accessibility help menu to one that suggests using shift+tab to explore the available actions, citing disabling this hint as an example.
  • Enables navigating to the next/previous completion from within the accessible view
  • Allows accepting the completion from within the accessible view
  • Announces not just the partial text, but the full completion to the screen reader - this makes more sense IMO

fix #186307

@meganrogge meganrogge requested a review from hediet August 15, 2023 23:01
@meganrogge meganrogge self-assigned this Aug 15, 2023
@meganrogge meganrogge added this to the August 2023 milestone Aug 15, 2023
@meganrogge meganrogge marked this pull request as draft August 15, 2023 23:04
@meganrogge meganrogge marked this pull request as ready for review August 16, 2023 19:09
@meganrogge meganrogge enabled auto-merge August 16, 2023 19:43
@meganrogge meganrogge merged commit 4e59c47 into main Aug 16, 2023
@meganrogge meganrogge deleted the merogge/inline-completions-accessibility branch August 16, 2023 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Accessibility View and Accessibility Help Menu for Copilot Inline Suggestions
3 participants