Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debt - properly await runWithFakedTimers #192887

Merged
merged 3 commits into from
Sep 12, 2023
Merged

debt - properly await runWithFakedTimers #192887

merged 3 commits into from
Sep 12, 2023

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Sep 12, 2023

No description provided.

@bpasero bpasero enabled auto-merge (squash) September 12, 2023 15:17
@bpasero bpasero self-assigned this Sep 12, 2023
@vscodenpa vscodenpa added this to the September 2023 milestone Sep 12, 2023
@ReyBan82 ReyBan82 mentioned this pull request Sep 12, 2023
Tyriar
Tyriar previously approved these changes Sep 12, 2023
…nter: true`, and Tab per Project (fix #192801)"

This reverts commit 31a191b.
@bpasero bpasero merged commit ab3fbd7 into main Sep 12, 2023
@bpasero bpasero deleted the ben/due-swordtail branch September 12, 2023 15:39
lins0621 pushed a commit to lins0621/vscode that referenced this pull request Sep 14, 2023
* debt - properly await `runWithFakedTimers`

* UI Overlap With `window.nativeTabs: false`, `window.commandCenter: true`, and Tab per Project (fix microsoft#192801)

* Revert "UI Overlap With `window.nativeTabs: false`, `window.commandCenter: true`, and Tab per Project (fix microsoft#192801)"

This reverts commit 31a191b.
hhc87 pushed a commit to lins0621/vscode that referenced this pull request Oct 8, 2023
* debt - properly await `runWithFakedTimers`

* UI Overlap With `window.nativeTabs: false`, `window.commandCenter: true`, and Tab per Project (fix microsoft#192801)

* Revert "UI Overlap With `window.nativeTabs: false`, `window.commandCenter: true`, and Tab per Project (fix microsoft#192801)"

This reverts commit 31a191b.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants