support getting various document ranges from InteractiveSessionProviders #193656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create a separate type to represent a response part * rename existing `ResponsePart` to `InternalResponsePart` * fix? handle if response part's resolved value is a markdown string, which is allowed in the `IResponse` interface
…veSessionProvider's
ulugbekna
force-pushed
the
ulugbekna/implement-code-mappers-context
branch
from
b2ff67c
to
a25b86c
Compare
ulugbekna
force-pushed
the
ulugbekna/implement-code-mappers-context
branch
from
a25b86c
to
63080ad
Compare
ulugbekna
changed the title
roblourens
reviewed
Sep 21, 2023
| @@ -138,7 +138,22 @@ declare module 'vscode' { | |||
| treeData: FileTreeData; | |||
| } | |||
|
|
|||
| export type InteractiveProgress = InteractiveProgressContent | InteractiveProgressId | InteractiveProgressTask | InteractiveProgressFileTree; | |||
| export interface DocumentContext { | |||
There was a problem hiding this comment.
Does this work if there are multiple codeblocks? Does the context need to be associated with one of the codeblocks somehow?
There was a problem hiding this comment.
We intend for this context to be associated with all codeblocks that occur a single reply for now. We can try associating a code block in the reply with ranges in documents but it's farther in the future.
| @@ -162,6 +186,8 @@ export class Response implements IResponse { | |||
| } else if (isCompleteInteractiveProgressTreeData(responsePart)) { | |||
| this._responseParts.push(responsePart); | |||
| this._updateRepr(quiet); | |||
| } else if ('documents' in responsePart) { | |||
| this._usedContext = responsePart; | |||
There was a problem hiding this comment.
The API would imply that it's valid to send multiple UsedContext pieces
There was a problem hiding this comment.
This occurred to me as well. I think it makes sense in future to aggregate all IUsedContext progress reports. What do you think?
|
There are some integration tests related to mapped edits failing, I'll soon fix them |
jrieken
approved these changes
Sep 22, 2023
yiliang114
pushed a commit
to yiliang114/vscode
that referenced
this pull request
Sep 25, 2023
…t-code-mappers-context support getting various document ranges from InteractiveSessionProviders
yiliang114
pushed a commit
to yiliang114/vscode
that referenced
this pull request
Sep 26, 2023
…t-code-mappers-context support getting various document ranges from InteractiveSessionProviders
yiliang114
pushed a commit
to yiliang114/vscode
that referenced
this pull request
Sep 30, 2023
…t-code-mappers-context support getting various document ranges from InteractiveSessionProviders
yiliang114
pushed a commit
to yiliang114/vscode
that referenced
this pull request
Oct 9, 2023
…t-code-mappers-context support getting various document ranges from InteractiveSessionProviders
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add support for getting various documents ranges from
InteractiveSessionProviders as part ofprovideResponseWithProgress. This allows passing that information to mapped-edit providers (aka code mappers).We also update the API of mappedEditsProvider's.
Support for persisting document ranges across vscode sessions will happen in another PR, if that's okay with @jrieken and @roblourens