Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to hide editor title section entirely (tabs, breadcrumbs) (#33607) #195222

Merged
merged 12 commits into from
Oct 18, 2023
Merged

Allow to hide editor title section entirely (tabs, breadcrumbs) (#33607) #195222

merged 12 commits into from
Oct 18, 2023

Conversation

benibenj
Copy link
Contributor

Allow to hide editor title section entirely (tabs, breadcrumbs) #33607

Changing showTabs from boolean to enum:

  • multiple: Multiple tabs with breadcrumbs below (if enabled)
  • single: One tab filling the entire width of the tab bar (this is the breadcrumb)
  • none: No tabs, no breadcrumbs

@benibenj benibenj requested a review from bpasero October 10, 2023 07:38
@benibenj benibenj self-assigned this Oct 10, 2023
@vscodenpa vscodenpa added this to the October 2023 milestone Oct 10, 2023
@bpasero bpasero changed the title Benibenj/noTabBar Allow to hide editor title section entirely (tabs, breadcrumbs) (#33607) Oct 10, 2023
bpasero
bpasero requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

Besides my inline feedback, can you do a fulltext search over showTabs, there are still a few cases that treat the setting as boolean, specifically:

  • ToggleTabsVisibilityAction
  • settings description (This value is ignored when #workbench.editor.showTabs# is disabled)
  • some context key expressions (ContextKeyExpr.has('config.workbench.editor.showTabs'))

src/vs/workbench/browser/workbench.contribution.ts Show resolved Hide resolved
src/vs/workbench/browser/workbench.contribution.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/layout.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/editorTitleControl.ts Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/noEditorTabsControl.ts Outdated Show resolved Hide resolved
@benibenj
Copy link
Contributor Author

What about the toggle tab visibility? I think we should turn it into two commands which we can show on the tabs container. hide editor tabs and single editor tab. Not sure about the naming yet. We could make the hide editor tab also available on the single tab (maybe also show multiple tabs).

@benibenj benibenj requested a review from bpasero October 18, 2023 10:10
@benibenj benibenj requested a review from bpasero October 18, 2023 13:28
@bpasero bpasero self-requested a review October 18, 2023 14:19
@benibenj @bpasero
Update src/vs/workbench/browser/parts/editor/editor.contribution.ts
e262512 
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
@benibenj benibenj merged commit 276d00c into main Oct 18, 2023
6 checks passed
@benibenj benibenj deleted the benibenj/noTabBar branch October 18, 2023 14:34
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@benibenj @Alex0007
Merge pull request microsoft#195222 from microsoft/benibenj/noTabBar
b8df51b 
Allow to hide editor title section entirely (tabs, breadcrumbs) (microsoft#33607)
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@benibenj benibenj

Labels
None yet
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@benibenj @bpasero @vscodenpa