adjust focused cell anchor behavior when resizing cells #195309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
approved these changes
Oct 10, 2023
rebornix
reviewed
Oct 11, 2023
| if (focused && (anchorFocusedSetting === 'on' || scrollHeuristic)) { | ||
| this.view.updateElementHeight(index, size, focus); | ||
| // If the cell is growing, we should favor anchoring to the focused cell | ||
| if (focused) { |
There was a problem hiding this comment.
@amunger should we check focus other than focused: number[]?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #194516
#195283 reduced the amount of resizing that cells do, so this PR attempts to make the auto setting for anchoring the focused cell work more smoothly.
Basically, anchor to the focused cell if
Shrinking an output is less common since an output won't be resized as the cell is executing, so issues like #193835 shouldn't occur anymore