Remove win32-ia32 target #195559
Merged
Remove win32-ia32 target #195559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
previously approved these changes
Oct 13, 2023
joaomoreno
dismissed stale reviews from roblourens and connor4312
via
d5aa58e
sandy081
requested changes
Oct 16, 2023
src/vs/platform/extensionManagement/common/extensionManagement.ts
Outdated
Show resolved
Hide resolved
|
@joaomoreno Should we also drop the support for |
Yes, this will follow suit. |
sandy081
previously approved these changes
Oct 16, 2023
sandy081
approved these changes
Oct 16, 2023
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
* remove win32-ia32 * update distro
nvarner
added a commit
to nvarner/typst-lsp
that referenced
this pull request
Nov 1, 2023
Based on microsoft/vscode-vsce#908 and microsoft/vscode#195559, it appears that extensions should no longer be published for the now removed win32-ia32 target.
nvarner
added a commit
to nvarner/typst-lsp
that referenced
this pull request
Nov 1, 2023
Based on microsoft/vscode-vsce#908 and microsoft/vscode#195559, it appears that extensions should no longer be published for the now removed win32-ia32 target.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This not only removes Windows 32-bit as a VS Code target, but ia32 support altogether since win32-ia32 was the last ia32 target supported. The last 32-bit target supported is linux-armhf.
To do before merging:
Would be great to get the following eyes on this: