Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS Version Selector When Local Version === Global Version #19593

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Jan 30, 2017

Bug
When the global tsdk setting points to the workspace version of typescript, our ts selector interface can get confused on which version is currently active

Fix
Adds a check using the local storage value to show the correct active version

**Bug**
When the global tsdk setting points to the workspace version of typescript, our ts selector interface can get confused on which version is currently active

**Fix**
Adds a check using the local storage value to show the correct active version
@mjbvz mjbvz merged commit c01ba26 into microsoft:master Jan 30, 2017
mjbvz added a commit that referenced this pull request Jan 31, 2017
**Bug**
When the global tsdk setting points to the workspace version of typescript, our ts selector interface can get confused on which version is currently active

**Fix**
Adds a check using the local storage value to show the correct active version
sandy081 pushed a commit that referenced this pull request Jan 31, 2017
**Bug**
When the global tsdk setting points to the workspace version of typescript, our ts selector interface can get confused on which version is currently active

**Fix**
Adds a check using the local storage value to show the correct active version
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants