New tsdk flow for 19 #19602
Merged
New tsdk flow for 19 #19602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows users to opt into using their workspace typescript.tsdk setting to specify the path to their typescript install. Also, fixes a bug when the global tsdk setting points to the workspace version of typescript, our ts selector interface can get confused on which version is currently active. The fix adds a check using the local storage value to show the correct active version.
mjbvz
added a commit
that referenced
this pull request
Jan 31, 2017
* Allow using workspace typescript.tsdk setting Allows users to opt into using their workspace typescript.tsdk setting to specify the path to their typescript install. Also, fixes a bug when the global tsdk setting points to the workspace version of typescript, our ts selector interface can get confused on which version is currently active. The fix adds a check using the local storage value to show the correct active version. * Flip vscode and workspace pick order * Use shared logic when workspace tsdk setting is not used
sandy081
pushed a commit
that referenced
this pull request
Jan 31, 2017
* Allow using workspace typescript.tsdk setting Allows users to opt into using their workspace typescript.tsdk setting to specify the path to their typescript install. Also, fixes a bug when the global tsdk setting points to the workspace version of typescript, our ts selector interface can get confused on which version is currently active. The fix adds a check using the local storage value to show the correct active version. * Flip vscode and workspace pick order * Use shared logic when workspace tsdk setting is not used
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback in #19451
Allows users to opt into using their workspace typescript.tsdk setting to specify the path to their typescript install.
Also, fixes a bug when the global tsdk setting points to the workspace version of typescript, our ts selector interface can get confused on which version is currently active. The fix adds a check using the local storage value to show the correct active version.