Allow additional extension data from Issue Reporter API #196103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* laying the groundwork for issue reporter API * working version 1 * added additional support, checkbox * smol change with disabling edits and cleanup * added blocker, timeout of 5 seconds, instead of rejecting we return * added working template data as well * removed test code * cleaning up commit * working with injecting template and allowing editing * cleanup pass 1 * added progress bar and code cleanup * cleanup and adding docs
| @@ -120,6 +124,12 @@ ${this.getInfos()} | |||
| private getInfos(): string { | |||
| let info = ''; | |||
|
|
|||
| if (this._data.issueType === IssueType.Bug || this._data.issueType === IssueType.PerformanceIssue) { | |||
There was a problem hiding this comment.
man this function makes my head hurt. So many ifs... we should clean this up in debt week.
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
TylerLeonhardt
approved these changes
Oct 23, 2023
Alex0007
pushed a commit
to Alex0007/vscode
that referenced
this pull request
Oct 26, 2023
…6103) * issue-reporter-main merge into branch (microsoft#13) * laying the groundwork for issue reporter API * working version 1 * added additional support, checkbox * smol change with disabling edits and cleanup * added blocker, timeout of 5 seconds, instead of rejecting we return * added working template data as well * removed test code * cleaning up commit * working with injecting template and allowing editing * cleanup pass 1 * added progress bar and code cleanup * cleanup and adding docs * added default data in issuereporter test * extension data hidden by default, better loading indication * cleanup * added codicons * added codicon styling, removed progress bar: * code cleanup * better preview button handling * cleaning up part 4 Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com> --------- Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regarding #46726
Laying initial groundwork and proposed API.