Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to node as default for moduleResolution #197032

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Switch back to node as default for moduleResolution #197032

merged 1 commit into from
Oct 30, 2023

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Oct 30, 2023 •
edited
Loading

Fixes #196554

Looks like bundler breaks require() intellisense. Reverts part of 6ebac17

@mjbvz
Switch back to node as default for moduleResolution
a8ff1fa 
Fixes microsoft#196554

Looks like bundler breaks `require()` intellisense
@mjbvz mjbvz added the candidate Issue identified as probable candidate for fixing in the next release label Oct 30, 2023
@mjbvz mjbvz added this to the November 2023 milestone Oct 30, 2023
@mjbvz mjbvz self-assigned this Oct 30, 2023
@mjbvz mjbvz enabled auto-merge (squash) October 30, 2023 22:43
@mjbvz mjbvz merged commit 60182c7 into microsoft:release/1.84 Oct 30, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bhavyaus bhavyaus bhavyaus approved these changes

Assignees

@mjbvz mjbvz

Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@mjbvz @bhavyaus