-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements first iteration of multi diff editors. #197652
Conversation
Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was only looking at a few files, not the larger pieces and left some feedback. I am adding @lramos15 for reviewing the editor resolver changes.
I'm guessing there is, but just for my understanding is there a reasoning for not making this a one off editor type like Chat, Search, the Perf graph, etc instead of adding an entire new editor type that my guess is won't be implemented elsehwere |
I was wondering the same. Let's start with this and refactor later. |
Is it only for Git (VCS) view for now (at least this is my impression after glancing over this PR code)? {
"key": "ctrl+d",
"command": "compareSelected",
"when": "listDoubleSelection && activeViewlet == 'workbench.view.explorer'"
}, |
We will slowly integrate it into other features as well.
This is out of scope for this feature, but maybe this can be implemented by an extension. |
Tasks left:
Fixes #179000