Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab title is covered when italic #200310

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

yiliang114
Copy link
Contributor

After modification:
bug8

Fixes #200309

@yiliang114
Copy link
Contributor Author

This line of code was originally added to solve this problem #122656. At present, deleting this line of code will not reintroduce this problem.

@benibenj
Copy link
Contributor

benibenj commented Dec 8, 2023

I don't see the bug that you are trying to fix. How can I reproduce it? Can you send an image of how the bug looks?

@benibenj benibenj added the info-needed Issue requires more information from poster label Dec 8, 2023
@yiliang114
Copy link
Contributor Author

I don't see the bug that you are trying to fix. How can I reproduce it? Can you send an image of how the bug looks?

hi @benibenj The screenshot of the problem is:

image

Reproduction steps in this issue #200309

yiliang114 and others added 20 commits December 10, 2023 18:29
…Code

Fixed issue Misalignment of suggestion details widget (microsoft/monaco-editor#3373)
…ettingsForTheLightbulb

Changing the settings for the lightbulb code action menu
Fix vscode.tasks.executeTask error Unexpected: Task does not exist after task.terminate()
Fix for microsoft#200257 plus existing trailing non-numerics regex fix
Fix task progress indicator does not appear after the first time
fix: `install` in `npm script` shouldn't be opened
@yiliang114
Copy link
Contributor Author

hi, someone have time to take a look at this pr?

@benibenj benibenj removed the info-needed Issue requires more information from poster label Jan 23, 2024
@benibenj
Copy link
Contributor

Sorry about the wait. I'll have a look at it next week. I was having a hard time reproducing the bug the last time I tried.

@yiliang114
Copy link
Contributor Author

Sorry about the wait. I'll have a look at it next week. I was having a hard time reproducing the bug the last time I tried.

Thank you for your time~

@bpasero
Copy link
Member

bpasero commented Apr 8, 2024

I think the better fix is to go back what we had to address this, see #207409 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab title is covered when italic
10 participants