Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates workbench.action.generateColorTheme command to return content #200403

Conversation

gdomingu
Copy link

@gdomingu gdomingu commented Dec 8, 2023

This PR would allow users to execute the generateColorTheme command programmatically with an option to return the theme content as JSON rather than opening the content in a new editor tab. This is useful for authors of extensions who want to style their webviews with the same theme as the rest of the editor. Specifically those with embedded editors or code snippets.

const themeJSON = await commands.executeCommand('workbench.action.generateColorTheme', false);

Tracked in: https://github.com/github/copilot-client/issues/4460
Related #168190
Also related #32813

@gdomingu gdomingu marked this pull request as ready for review December 11, 2023 17:38
@aeschli
Copy link
Contributor

aeschli commented Dec 12, 2024

Sorry, this looks like a misuse of an existing command and a workaround for missing API.
#32813 is the way to go.

@aeschli aeschli closed this Dec 12, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants