Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto save - skip non-dirty editors #200468

Merged
merged 1 commit into from
Dec 10, 2023
Merged

auto save - skip non-dirty editors #200468

merged 1 commit into from
Dec 10, 2023

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Dec 10, 2023

No description provided.

@bpasero bpasero self-assigned this Dec 10, 2023
@bpasero bpasero enabled auto-merge (squash) December 10, 2023 06:58
!editorIdentifier.editor.isDirty() ||
editorIdentifier.editor.isReadonly() ||
editorIdentifier.editor.hasCapability(EditorInputCapabilities.Untitled)
) {
return; // no auto save for readonly or untitled editors
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray Dec 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add non-dirty to this comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

@bpasero bpasero merged commit 8edc58a into main Dec 10, 2023
7 checks passed
@bpasero bpasero deleted the ben/changing-termite branch December 10, 2023 09:19
@bonzzo2014 bonzzo2014 mentioned this pull request Dec 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants