Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to store/resume open editors across Continue On transitions (fix #193704) #201631

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Allow to store/resume open editors across Continue On transitions (fix #193704) #201631

merged 3 commits into from
Jan 4, 2024
+217 −82

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Dec 30, 2023 •
edited
Loading

fix #193704

@bpasero bpasero self-assigned this Dec 30, 2023
@bpasero bpasero added this to the December / January 2024 milestone Dec 30, 2023
@bpasero bpasero marked this pull request as ready for review December 31, 2023 07:19
@bpasero
Copy link
Member Author

bpasero commented Dec 31, 2023 •
edited
Loading

@joyceerhl this implements support to update editor state when the underlying storage changes (in 2 locations to support both floating windows and main window).
However, so far I was not able to figure out how to test roaming locally to ensure this actually works with how we store state today. As you can see, the change does not go into any of the editor input serialisers (yet) because it may just work 🤞

joyceerhl
joyceerhl reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@joyceerhl joyceerhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I verified this PR will restore editor state with a local test in Code-OSS:

  • Clone the same repo twice and open one clone in VS Code
  • Use Cloud Changes: Store Working Changes in Cloud to store editor state in one clone
  • Open the other cloned repo, the stored editor state is restored since both clones have the same identity

src/vs/workbench/common/component.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/editorParts.ts Outdated Show resolved Hide resolved
@bpasero bpasero enabled auto-merge (squash) January 4, 2024 10:14
@bpasero bpasero merged commit 901ba07 into main Jan 4, 2024
6 of 17 checks passed
@bpasero bpasero deleted the ben/misleading-kite branch January 4, 2024 10:28
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joyceerhl joyceerhl joyceerhl left review comments

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to store/resume open editors across Continue On transitions
3 participants
@bpasero @joaomoreno @joyceerhl