Workbench - add activeRepositoryName and activeRepositoryBranchName variables #204393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
requested changes
Feb 6, 2024
There was a problem hiding this comment.
I think the idea of using context keys is OK and see #202991 for an related issue for extensions to leverage this further.
But I am not a big fan of making the window title dependent on all possible keys, esp. given SCM is a contrib but the title bar is not.
I think we need some kind of way for contrib to contribute variables to the window title. Since we need this early in workbench.contribution.ts, maybe we should have some kind of static registry for it, similar to registerAction2.
|
@bpasero, got it. Let me take a stab at it and will make sure to have you review the PR. |
|
Closing PR as we will pursue another solution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #197498
@bpasero, do you mind taking a look at this PR to make sure that I did not miss something? Thank you!