-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fetch prune & delete command #205031
base: main
Are you sure you want to change the base?
feat: add fetch prune & delete command #205031
Conversation
Co-authored-by: Ladislau Szomoru <lszomoru@microsoft.com>
Co-authored-by: Ladislau Szomoru <lszomoru@microsoft.com>
Co-authored-by: Ladislau Szomoru <lszomoru@microsoft.com>
Hey everyone, I’m going to take a look at this PR within a month and add tests and refactor if eligible. Afterwards I’ll try to contact maintainers for review. Thank you for your patience. |
// TODO: origin is hardcoded | ||
.map((el) => el.match(branchRegex)?.[1]?.replace('origin/', '') ?? '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// TODO: origin is hardcoded | |
.map((el) => el.match(branchRegex)?.[1]?.replace('origin/', '') ?? '') | |
.map((el) => el.match(branchRegex)?.[1]?.replace('origin/', '') ?? '') |
I don't think there will be edge cases for remote origin
, or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @lszomoru, I hope you're doing well! I wanted to check in regarding a PR that's been waiting for your review for a year now. Could you let me know if you're able to take a look in the near future? |
Hi, sorry to ping you as this PR been getting much attention from the community, but unfortunately, it hasn't received any feedback for a year now. I've opened this PR encouraged by #183906 (comment), hope this PR gets any feedback from the team. |
I am using |
This PR is port of closed PR #183955
Resolves #183906