Add tips for debug views #205861
Merged
Add tips for debug views #205861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiliang114
commented
Feb 21, 2024
| @@ -296,7 +296,7 @@ viewsRegistry.registerViewWelcomeContent(EmptyView.ID, { | |||
| }); | |||
|
|
|||
| viewsRegistry.registerViewWelcomeContent(EmptyView.ID, { | |||
| content: localize({ key: 'noFolderHelpWeb', comment: ['Please do not translate the word "commmand", it is part of our internal syntax which must not change'] }, | |||
There was a problem hiding this comment.
Could many comments here be deleted in fact? Because there is no command string in the actual copy.
There was a problem hiding this comment.
It's possible, but I don't want to do that for another feature area in this PR
roblourens
approved these changes
Feb 21, 2024
| @@ -296,7 +296,7 @@ viewsRegistry.registerViewWelcomeContent(EmptyView.ID, { | |||
| }); | |||
|
|
|||
| viewsRegistry.registerViewWelcomeContent(EmptyView.ID, { | |||
| content: localize({ key: 'noFolderHelpWeb', comment: ['Please do not translate the word "commmand", it is part of our internal syntax which must not change'] }, | |||
There was a problem hiding this comment.
It's possible, but I don't want to do that for another feature area in this PR
aeschli
approved these changes
Feb 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong translation
However, I know that the repair of the copy needs to be
vscode-locin the warehouse, but a hint has been added here.Such as
https://github.com/microsoft/vscode-loc/blob/b0beccc0d53c8f2353ac6d469cd5f68d2e0806d3/i18n/vscode-language-pack-zh-hans/translations/main.i18n.json#L6296