feat. add a menu item 'expand-select' to expand subtree in search view

[pagict]

Implementation of #206032

[RedCMD]

Middle click (scroll click/button 3) is often used for toggling between expanding and collapsing nested items
(just like folding ranges in the editor)

[pagict]

@microsoft-github-policy-service agree

[andreamah]

Just a few small changes 👍

[andreamah]

Middle click (scroll click/button 3) is often used for toggling between expanding and collapsing nested items (just like folding ranges in the editor)

I think the search view already supports this, where middle click expands one level. Is this what you meant, or is there still missing functionality?

[pagict]

Middle click (scroll click/button 3) is often used for toggling between expanding and collapsing nested items (just like folding ranges in the editor)

I think the search view already supports this, where middle click expands one level. Is this what you meant, or is there still missing functionality?

I meant for recursive expansion. I will update my code to make work, thx for reviewing.

[RedCMD]

I think the search view already supports this, where middle click expands one level. Is this what you meant, or is there still missing functionality?

yeah I meant for recursively nested items
The same as Folding ranges in the editor

[andreamah]

I think the search view already supports this, where middle click expands one level. Is this what you meant, or is there still missing functionality?

yeah I meant for recursively nested items The same as Folding ranges in the editor

As in the middle click should recursively open nested items? Does this only happen in the editor with nested ranges, or does it happen in other tree views?

[RedCMD]

yes, I would like middle click to recursively open nested items.
I think it only works for Folding ranges atm
I don't think any other tree view supports it

I'm pretty sure there was something else that did support it
but I can't remember if it was even in VSCode or not

[pagict]

I tried and also checked the code, "middle mouse for recursively expansion" only works for foldings in the editor.

vscode/src/vs/editor/contrib/folding/browser/folding.ts

Lines 492 to 499 in 1f94e5c

	const recursive = e.event.middleButton || e.event.shiftKey;
	if (recursive) {
	for (const r of foldingModel.getRegionsInside(region)) {
	if (r.isCollapsed === isCollapsed) {
	toToggle.push(r);
	}
	}
	}

[andreamah]

Do we use the language "Expand Selected" anywhere else? Otherwise, I would prefer just "Expand" since it's implied that it's acting on selected elements.

[pagict]

Do we use the language "Expand Selected" anywhere else? Otherwise, I would prefer just "Expand" since it's implied that it's acting on selected elements.

no, the term "Expand Selected" does not in anywhere else. should I modify it as "Expand the Tree" or something similar, since this is quite a different behavior to what "Expand" implies.

[andreamah]

The button that expands/collapses all (in the top toolbar) uses the term "Expand all" to expand all of the tree nodes, so I would expect that right-clicking and "expanding" a node would recursively open the node.

[pagict]

The button that expands/collapses all (in the top toolbar) uses the term "Expand all" to expand all of the tree nodes, so I would expect that right-clicking and "expanding" a node would recursively open the node.

update as "Expand All", please kindly review

[andreamah]

I'm not too sure about "Expand All". Notice that the context menu has a "copy all" that actually addresses the entire search result, even if clicked on one node.

How about "Expand Recursively"?

[pagict]

I think they both are good, and how about "Expand from This"? or maybe should be more succinct.

I don't have any preferences on this

[andreamah]

I think "Expand Recursively" would be the best from my perspective, since it seems less wordy in my opinion.

[andreamah]

Thanks!