Enable shell integration in hidden terminals #208036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I understand it, hidden terminals were always exempty from shell integration because hidden terminals were thought of as private to an extension in a way, and also since they probably weren't going to be interacted with. Especially since the introduction of the environment variable collection API I think we should change this decision, not doing so will lead to weirdness for extensions where hidden ones (which may be shown later) aren't fully featured and get inconsistent envs. Fixes #199611 Part of #197187
karrtikr
approved these changes
Mar 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand it, hidden terminals were always exempty from shell integration because hidden terminals were thought of as private to an extension in a way, and also since they probably weren't going to be interacted with. Especially since the introduction of the environment variable collection API I think we should change this decision, not doing so will lead to weirdness for extensions where hidden ones (which may be shown later) aren't fully featured and get inconsistent envs.
Fixes #199611
Part of #197187
A
hideFromUserterminal after showing: