fix #209091 #209454
Merged
fix #209091 #209454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lszomoru
approved these changes
Apr 3, 2024
|
I am sorry, I strongly disagrees how this issue / PR was handled. Clearly there was already a PR to the issue, why couldn't you merge it instead. Closing the original author's PR and reopening a new one but there is no mention to the origin author in the commit message makes us feel incredibly sad about contributing to VSCode in the future. |
jakecastelli
added a commit
to jakecastelli/vscode
that referenced
this pull request
Apr 3, 2024
This reverts commit e8e027a.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #209091